Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate: find+replace DrawBoundary dataFieldBoundary prop to fn and remove dataFieldArea prop #594

Merged
merged 3 commits into from
Jan 7, 2025
Merged

migrate: find+replace DrawBoundary dataFieldBoundary prop to fn and remove dataFieldArea prop #594

merged 3 commits into from
Jan 7, 2025

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Dec 17, 2024 •
edited
Loading

@jessicamcinchak jessicamcinchak mentioned this pull request Dec 17, 2024
Merged
@jessicamcinchak jessicamcinchak marked this pull request as ready for review January 6, 2025 15:36
@jessicamcinchak jessicamcinchak requested a review from a team January 6, 2025 15:36
@jessicamcinchak jessicamcinchak changed the title wip: find+replace DrawBoundary dataFieldBoundary prop to fn and remove dataFieldArea prop migrate: find+replace DrawBoundary dataFieldBoundary prop to fn and remove dataFieldArea prop Jan 6, 2025
RODO94
RODO94 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, couldn't find any misplaced changes, typos, or overlooked properties.

@jessicamcinchak jessicamcinchak merged commit ba2cde0 into main Jan 7, 2025
3 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/drawBoundary-dataFieldBoundary-to-fn branch January 7, 2025 16:25
@jessicamcinchak jessicamcinchak mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RODO94 RODO94 RODO94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamcinchak @RODO94